Skip to content

src: improve error handling in node_http2 #57764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

src: improve error handling in node_http2 #57764

wants to merge 1 commit into from

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Apr 5, 2025

More general error handling improvements

@jasnell jasnell requested a review from aduh95 April 5, 2025 18:42
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Apr 5, 2025
aduh95
aduh95 reviewed Apr 5, 2025
View reviewed changes
@codecov

This comment was marked as outdated.

Sign in to view
mcollina
mcollina approved these changes Apr 6, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 6, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 6, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/66090/ 💛

@mcollina mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 7, 2025
jasnell added a commit that referenced this pull request Apr 7, 2025
@jasnell
src: improve error handling in node_http2
08a7df8 
PR-URL: #57764
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@jasnell
Copy link
Member Author

jasnell commented Apr 7, 2025

Landed in 08a7df8

@jasnell jasnell closed this Apr 7, 2025
JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
@jasnell @JonasBa
src: improve error handling in node_http2
e3ad754 
PR-URL: nodejs#57764
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@jasnell @RafaelGSS
src: improve error handling in node_http2
8763d7f 
PR-URL: #57764
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@jasnell @RafaelGSS
src: improve error handling in node_http2
fc52955 
PR-URL: #57764
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@jasnell @aduh95
src: improve error handling in node_http2
f2e8551 
PR-URL: #57764
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@jasnell @RafaelGSS
src: improve error handling in node_http2
4a22d1d 
PR-URL: #57764
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@jasnell @aduh95
src: improve error handling in node_http2
b405a74 
PR-URL: #57764
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@jasnell @aduh95
src: improve error handling in node_http2
6e96e5c 
PR-URL: #57764
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@jasnell @aduh95
src: improve error handling in node_http2
d04c2a8 
PR-URL: #57764
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@jasnell @aduh95
src: improve error handling in node_http2
3ae138f 
PR-URL: #57764
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@jasnell @aduh95
src: improve error handling in node_http2
db483bb 
PR-URL: #57764
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@ghost ghost mentioned this pull request Jun 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue Add this label to land a pull request using GitHub Actions. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jasnell @nodejs-github-bot @mcollina @aduh95